Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][interp] Implement tailcalls #59799

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Sep 30, 2021

Before this commit we supported tailcalls only for calls to the same method. Tailcalls are implemented by copying the call arguments to the start of the stack space, followed by replacing of the current executing method.

Contributes to #54374

@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Before this commit we supported tailcalls only for calls to the same method. Tailcalls are implemented by copying the call arguments to the start of the stack space, followed by replacing of the current executing method.

Contributes to #54374

Author: BrzVlad
Assignees: -
Labels:

area-Codegen-Interpreter-mono

Milestone: -

@BrzVlad BrzVlad force-pushed the feature-interp-tailcall branch from 2d6b3e0 to 343706b Compare September 30, 2021 13:29
@marek-safar
Copy link
Contributor

@vargaz please review

Before this commit we supported tailcalls only for calls to the same method. Tailcalls are implemented by copying the call arguments to the start of the stack space, followed by replacing of the current executing method.
@SamMonoRT
Copy link
Member

@BrzVlad @vargaz - I believe this just needs a review. All checks and re-enabled test pass now.

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants